New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace management #579

Merged

sudermanjr merged 1 commit into master from sudermanjr/fix-ns-mgmt

Apr 25, 2022

Member

sudermanjr commented Apr 22, 2022 •

edited

Loading

This PR fixes #568

Checklist

I have signed the CLA
I have updated/added any relevant documentation

Description

What changes did you make?

Reorganized the namespace code slightly.
Added unit tests to cover this test case
Added some other unit tests that were low-hanging fruit in the course package (66.3% coverage on course)
Fixed the merge namespace function to not modify the original defaults object

What alternative solution should we consider, if any?

n/a

sudermanjr marked this pull request as ready for review

April 25, 2022 16:09

sudermanjr requested a review from lucasreed as a code owner

April 25, 2022 16:09

sudermanjr requested a review from intrand

April 25, 2022 16:20

sudermanjr closed this

sudermanjr reopened this


Fix namespace management

2f57a48

sudermanjr force-pushed the sudermanjr/fix-ns-mgmt branch from 19ee16a to 2f57a48 Compare

April 25, 2022 18:27

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

No Coverage information
0.0% Duplication

intrand approved these changes

View reviewed changes

sudermanjr merged commit de1ad16 into master

sudermanjr deleted the sudermanjr/fix-ns-mgmt branch

April 25, 2022 19:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment