remove useless review-previewer component

Faithful-Resource-Pack · Dec 3, 2024 · 2b58ff7 · 2b58ff7
1 parent 389f1a1
commit 2b58ff7
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 57 deletions.
diff --git a/index.html b/index.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <html lang="en">
 	<head>
-		<meta charset="utf-8">
+		<meta charset="utf-8" />
 
 		<title>Faithful Web Application</title>
 		<meta name="theme-color" content="#76C945" />

diff --git a/index.js b/index.js
@@ -542,6 +542,8 @@ const app = new Vue({
 			axios.get(`${this.apiURL}/${url}`, this.apiOptions).then((r) => {
 				this.$set(this.badges, url, r.data.length || 0);
 			});
+			// since it's recursive you don't need setInterval
+			return setTimeout(() => loadBadge(url), 30000);
 		},
 		jsonSnackBar(json = undefined) {
 			return {
@@ -846,7 +848,7 @@ const app = new Vue({
 
 			subtabs.forEach((s) => {
 				// 30 seconds
-				if (s.badge) setInterval(() => this.loadBadge(s.badge), 30000);
+				if (s.badge) this.loadBadge(s.badge);
 			});
 
 			subtabs

diff --git a/pages/review/main.vue b/pages/review/main.vue
@@ -44,8 +44,8 @@ d88   888  888    888 d88   888
 							:empty="empty"
 						/>
 					</div>
-					<div id="review-previewer">
-						<review-preview :addonId="selectedAddonId" color="#9575cd" />
+					<div id="review-preview-container">
+						<review-preview :addonId="selectedAddonId" />
 					</div>
 				</template>
 				<template v-else>
@@ -80,7 +80,7 @@ import ExpansionPanel from "./expansion-panel.vue";
 import DenyPopup from "./deny-popup.vue";
 import ReviewCategories from "./review-categories.vue";
 import ReviewList from "./review-list.vue";
-import ReviewPreview from "./review-previewer.vue";
+import ReviewPreview from "./review-preview.vue";
 
 const searchMixin = {
 	methods: {

diff --git a/pages/review/review-list.vue b/pages/review/review-list.vue
@@ -6,7 +6,7 @@
 				v-for="(item, i) in items"
 				:key="item.key"
 				:class="classes[i]"
-				@click="() => onClick(item.key)"
+				@click="$emit('input', item.key)"
 			>
 				<v-list-item-content>
 					<v-list-item-title>{{ item.primary }}</v-list-item-title>
@@ -41,11 +41,6 @@ export default {
 			required: true,
 		},
 	},
-	methods: {
-		onClick(key) {
-			this.$emit("input", key);
-		},
-	},
 	computed: {
 		classes() {
 			return this.items.map((v) => (v.key === this.value ? `${this.activeColor} selected` : ""));

diff --git a/pages/review/review-preview.vue b/pages/review/review-preview.vue
@@ -13,7 +13,11 @@
 							<span class="text--secondary font-weight-regular">{{ `#${addonInPanel.id}` }}</span>
 						</h2>
 						<div class="text--secondary subtitle-2 mt-1" style="line-height: 14px">
-							{{ ([...addonInPanel.options.tags] || []).sort().join(" • ") }}
+							{{
+								Array.from(addonInPanel.options.tags || [])
+									.sort()
+									.join(" • ")
+							}}
 						</div>
 					</div>
 					<v-btn id="edit-btn" icon class="ml-auto" :href="`/addons/edit/${addonInPanel.id}`">
@@ -89,7 +93,7 @@
 							>
 								<li>
 									{{ file.name }} -
-									<a :href="file.source" class="text--secondary">
+									<a :href="file.source" target="_blank" class="text--secondary">
 										{{ $root.lang().review.addon.labels.link }}
 										<v-icon small color="light-blue">mdi-open-in-new</v-icon>
 									</a>

diff --git a/pages/review/review-previewer.vue b/pages/review/review-previewer.vue
diff --git a/resources/css/webapp.css b/resources/css/webapp.css
@@ -1114,15 +1114,11 @@ body .database-list-avatar {
 	overflow-y: auto;
 }
 
-#review-content #preview-here {
-	height: 100%;
-}
-
 #review-content #review-list {
 	width: 40%;
 }
 
-#review-content #review-previewer {
+#review-content #review-preview-container {
 	width: 60%;
 }