Use custom scrollbar for GroupSelector #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group selector has some complicated scrolling behavior, and not all browses displayed the scrollbar above the content. Sometimes, placing the content above the scrollbar. Using css to attempt to alter the scrollbar was not a viable solution due to Firefox not supporting the css required. Using a custom scrollbar allows us to have control over the location of the scrollbar and get a consistent look accross browsers.
JordanSjodinFaithlife
force-pushed
the
customscrollbar
branch
from
69edd57 to
b5d1ef4
Compare
| background: white; | ||
| border-radius: 4px; | ||
|
|
||
| .${ModalScrollViewContentClass} { |
There was a problem hiding this comment.
It would be better to pass in a reference to another component than to create a class name for it, can we do that here? Docs
There was a problem hiding this comment.
I can get around using this class name
| @@ -8167,6 +8197,14 @@ react-router@^3.2.0: | |||
| prop-types "^15.5.6" | |||
| warning "^3.0.0" | |||
|
|
|||
| react-scrollbar@^0.5.4: | |||
| version "0.5.4" | |||
| resolved "https://registry.yarnpkg.com/react-scrollbar/-/react-scrollbar-0.5.4.tgz#270576a28d0f7783b2304b284dbd38d82b36b0e0" | |||
There was a problem hiding this comment.
I'm a bit worried that this dependency (and react-motion) are going to bloat the main bundle. If we need this dependency, let's move anything that uses it to a separate bundle. This is how we did it for text-input
There was a problem hiding this comment.
I'll try this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dustinsoftware
The group selector has some complicated scrolling behavior, and not all browses displayed the scrollbar above the content.
Using css to attempt to alter the scrollbar was not a viable solution due to Firefox not supporting the css required.
Using a custom scrollbar allows us to have control over the location of the scrollbar and get a consistent look accross browsers.
Plus, fixed some small buttons on secondary modal content and fixed a gap in the header.