Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
There are two bugs in
regexify
that make #134 fail: whenregexify
is called with a dot (matches any character in regex), the dot may get replaced (byasciify
) with a backslash, which is an escape character:Faker/src/Faker/Provider/Base.php
Line 533 in c65e3b6
Secondly, all backslashes are removed - even the ones that are escaped:
Faker/src/Faker/Provider/Base.php
Line 535 in c65e3b6
Author's checklist
Summary of changes
This PR fixes the issues by checking whether
asciify
returns a backsash. In case it does it adds another backslash as escape character.Additionally escaped backslashes are not removed by
regexify
any more.Review checklist