Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for psr/container >= 2.0 #354

Merged
merged 3 commits into from
Jul 30, 2021
Merged

add support for psr/container >= 2.0 #354

merged 3 commits into from
Jul 30, 2021

Conversation

Lctrs
Copy link

@Lctrs Lctrs commented Jul 28, 2021

What is the reason for this PR?

Make the project compatible with psr/container >=2.0

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Updated Faker\Extension\Container to be compatible with psr/container >= 2.0 .
Tested that static analysis still pass with psr/container 1.0 (on PHP 7.4).

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

src/Faker/Extension/Container.php Outdated Show resolved Hide resolved
@GrahamCampbell
Copy link
Member

Tested that static analysis still pass with psr/container 1.0 (on PHP 7.4).

I don't think so: https://3v4l.org/aDKoX.

@Lctrs
Copy link
Author

Lctrs commented Jul 29, 2021

Tested that static analysis still pass with psr/container 1.0 (on PHP 7.4).

I don't think so: https://3v4l.org/aDKoX.

Hmmm, I must have done something wrong.

@Lctrs
Copy link
Author

Lctrs commented Jul 29, 2021

@GrahamCampbell Do you want me to create another PR for dropping support for PHP 7.1 ?

@GrahamCampbell
Copy link
Member

Hmm, not sure. The tests don't seem to be failing here on PHP 7.1.

@GrahamCampbell
Copy link
Member

Ah, nice version 2.0 requires PHP 7.2 or higher, so we don't need to drop PHP 7.1 for this to work. 🎉

I was anticipating this being an issue:

image

@GrahamCampbell
Copy link
Member

I'm happy with this after my adjustments. This is not BC breaking. :)

@pimjansen
Copy link

Lgtm

@pimjansen pimjansen merged commit 6298b7f into FakerPHP:main Jul 30, 2021
@Lctrs Lctrs deleted the feature/psr-container/v2 branch July 30, 2021 07:15
@hannesvdvreken
Copy link

hannesvdvreken commented Jul 30, 2021

git tag v1.15.1 -m 1.15.1; git push origin v1.15.1 pls thx


Lgtm Lctrs

@GrahamCampbell
Copy link
Member

This won't be v1.15.1. We follow semver, so this must be v1.16.0. There's no rush to tag here. You can install this using ^1.16 already, if you allow dev stability. Alternatively, you can force it with @dev.

@hannesvdvreken
Copy link

It's for Lctrs/psalm-psr-container-plugin#300, i doubt @Lctrs will set it's dependency on faker to a dev version 😛

@Lctrs
Copy link
Author

Lctrs commented Jul 30, 2021

I'm not in a rush as well. I'll actually set it to a dev version to unlock you @hannesvdvreken and not bother Faker's maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants