Add DateTime extension #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram-pkg
force-pushed
the
feature/date-extension-implementation
branch
from
56cad9d
to
d0eae54
Compare
bram-pkg
force-pushed
the
feature/date-extension-implementation
branch
from
016e0c8
to
48103fd
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
added 15 commits
March 1, 2022 23:40
bram-pkg
force-pushed
the
feature/date-extension-implementation
branch
from
588809c
to
9ef661e
Compare
pimjansen
approved these changes
Mar 8, 2022
| /** | ||
| * @var string[] | ||
| */ | ||
| private $centuries = ['I', 'II', 'III', 'IV', 'V', 'VI', 'VII', 'VIII', 'IX', 'X', 'XI', 'XII', 'XIII', 'XIV', 'XV', 'XVI', 'XVII', 'XVIII', 'XIX', 'XX', 'XXI']; |
There was a problem hiding this comment.
Cant we type the methods since we aim 7.4 anyways?
There was a problem hiding this comment.
Not from within our current 1.x release, right
We'll add those types in the 2.x release.
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
DateExtensionto Core #428)Author's checklist
Summary of changes
A
DateTimeExtensionwill be added as a care extension.Review checklist