Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DateTime extension #431

Merged
merged 16 commits into from
Mar 8, 2022
Merged

Conversation

bram-pkg
Copy link
Member

@bram-pkg bram-pkg commented Jan 22, 2022

What is the reason for this PR?

Author's checklist

Summary of changes

A DateTimeExtension will be added as a care extension.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@bram-pkg bram-pkg force-pushed the feature/date-extension-implementation branch from 56cad9d to d0eae54 Compare January 23, 2022 11:18
@bram-pkg bram-pkg force-pushed the feature/date-extension-implementation branch from 016e0c8 to 48103fd Compare February 2, 2022 17:43
@bram-pkg bram-pkg marked this pull request as ready for review February 2, 2022 19:18
@bram-pkg bram-pkg self-assigned this Feb 2, 2022
@bram-pkg bram-pkg added the enhancement New feature or request label Feb 2, 2022
@stale
Copy link

stale bot commented Feb 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

@bram-pkg bram-pkg force-pushed the feature/date-extension-implementation branch from 588809c to 9ef661e Compare March 1, 2022 22:40
/**
* @var string[]
*/
private $centuries = ['I', 'II', 'III', 'IV', 'V', 'VI', 'VII', 'VIII', 'IX', 'X', 'XI', 'XII', 'XIII', 'XIV', 'XV', 'XVI', 'XVII', 'XVIII', 'XIX', 'XX', 'XXI'];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant we type the methods since we aim 7.4 anyways?

Copy link
Member Author

@bram-pkg bram-pkg Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from within our current 1.x release, right

We'll add those types in the 2.x release.

@pimjansen
Copy link

Lgtm

@bram-pkg bram-pkg merged commit 571e062 into main Mar 8, 2022
@bram-pkg bram-pkg deleted the feature/date-extension-implementation branch March 8, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DateExtension to Core
2 participants