Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CZ Person birthNumber docblock return type #437

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Fix CZ Person birthNumber docblock return type #437

merged 3 commits into from
Jan 27, 2022

Conversation

krsriq
Copy link

@krsriq krsriq commented Jan 27, 2022

What is the reason for this PR?

The docblock of cs_CZ\Person::birthNumber() has a non existing return type czech.

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Fixed the docblock return type.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

pimjansen
pimjansen approved these changes Jan 27, 2022
View reviewed changes
Copy link

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@pimjansen pimjansen merged commit f368870 into FakerPHP:main Jan 27, 2022
@krsriq
Copy link
Author

krsriq commented Jan 27, 2022

Thanks!

@krsriq krsriq deleted the BUGFIX/cz_person_docblock branch January 27, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsriq @pimjansen