Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uuid method from Generator #443

Closed
wants to merge 1 commit into from
Closed

Conversation

simPod
Copy link

@simPod simPod commented Jan 31, 2022

What is the reason for this PR?

This method added in #427 is a BC break. I had a Provider with uuid function but this added a new Formatter with name uuid which has a precedence over Providers.

Author's checklist

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen
Copy link

Duplicate of #441

@pimjansen pimjansen closed this Jan 31, 2022
@pimjansen pimjansen added the duplicate This issue or pull request already exists label Jan 31, 2022
@pimjansen
Copy link

Technically it was not a BC however we understand the issue due to the __call methods.

So we discussing it internally. We have 2 options:

  • remove the methods
  • ensure the Extension interfaces go final.

I think the first option will be taken where the extension interfaces will be for 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants