Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Yemen Provider #665

Closed
wants to merge 3 commits into from
Closed

added Yemen Provider #665

wants to merge 3 commits into from

Conversation

zayedadel
Copy link

@zayedadel zayedadel commented Jul 1, 2023

What is the reason for this PR?

to be used in yemen specific projects

Author's checklist

Summary of changes

addressFormats()

is returned from the following function

/**
 * @example 'اليمن الامانة شارع السبعين'
 */
public static function yemenAddress()
{
    $country = 'اليمن';
    $governorate = static::randomElement(static::$governorates);
    $subdivision = static::randomElement(static::$subdivisions[$governorate]);
    $precinct = static::randomElement(static::$precincts[$subdivision]);

    return $country . ' محافظة ' . $governorate . ' مديرية ' . $subdivision . ' منطقة ' . $precinct;
}
can be found in Address Class

the rest of changes are cultural and country specific terms nothing major 

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@localheinz localheinz added the enhancement New feature or request label Jul 2, 2023
@zayedadel
Copy link
Author

zayedadel commented Jul 8, 2023

last pull will hopefully pass all tests @localheinz

@GlennM
Copy link

GlennM commented Jul 13, 2023

Thanks for your effort, but I believe that new features are blocked until Faker 2.0 has been released?

@zayedadel
Copy link
Author

@GlennM Ok no problem i'll wait until then before i do an other pull request. sorry for the inconvenience.

@stale
Copy link

stale bot commented Aug 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

@zayedadel
Copy link
Author

@localheinz should i create another pull request or wait until v2.0 or what exactly is the situation ?

@stale stale bot removed the lifecycle/stale label Aug 15, 2023
@zayedadel zayedadel closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants