Fix: Remove unused method #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/unused
branch
from
9220950
to
73231b6
Compare
localheinz
commented
Sep 4, 2023
Comment on lines
-141
to
-144
| public function getDefinitions(): array | ||
| { | ||
| return $this->definitions; | ||
| } |
There was a problem hiding this comment.
Not sure what the intention with this method was, but it is currently unused.
| /** | ||
| * Get the bindings between Extension interfaces and implementations. | ||
| */ | ||
| public function getDefinitions(): array; |
There was a problem hiding this comment.
Given that the ContainerInterface interface would now be empty, perhaps we should remove it?
There was a problem hiding this comment.
No harm is maintaining our own extension of it, in case it's needed.
bram-pkg
approved these changes
Sep 4, 2023
|
Thank you, @bram-pkg! |
renovate bot
referenced
this pull request
in RadioRoster/backend
Jan 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fakerphp/faker](https://togithub.com/FakerPHP/Faker) | `1.23.0` -> `1.23.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>FakerPHP/Faker (fakerphp/faker)</summary> ### [`v1.23.1`](https://togithub.com/FakerPHP/Faker/releases/tag/v1.23.1) [Compare Source](https://togithub.com/FakerPHP/Faker/compare/v1.23.0...v1.23.1) #### What's Changed - fix typos: "assymetric" -> asymmetric by [@​ivastly](https://togithub.com/ivastly) in [https://github.com/FakerPHP/Faker/pull/660](https://togithub.com/FakerPHP/Faker/pull/660) - Fix: lv_LV postcode format by [@​edgarsn](https://togithub.com/edgarsn) in [https://github.com/FakerPHP/Faker/pull/661](https://togithub.com/FakerPHP/Faker/pull/661) - composer(deps): bump vimeo/psalm from 5.12.0 to 5.13.1 in /vendor-bin/psalm by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/669](https://togithub.com/FakerPHP/Faker/pull/669) - composer(deps): bump rector/rector from 0.17.0 to 0.17.2 in /vendor-bin/rector by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/667](https://togithub.com/FakerPHP/Faker/pull/667) - composer(deps): bump phpstan/phpstan from 1.10.15 to 1.10.22 in /vendor-bin/phpstan by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/666](https://togithub.com/FakerPHP/Faker/pull/666) - composer(deps): bump friendsofphp/php-cs-fixer from 3.17.0 to 3.20.0 in /vendor-bin/php-cs-fixer by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/668](https://togithub.com/FakerPHP/Faker/pull/668) - Add `$format` to `image` DocBlock by [@​vintagesucks](https://togithub.com/vintagesucks) in [https://github.com/FakerPHP/Faker/pull/670](https://togithub.com/FakerPHP/Faker/pull/670) - Fix: lv_LV generating invalid personal identity numbers by [@​edgarsn](https://togithub.com/edgarsn) in [https://github.com/FakerPHP/Faker/pull/663](https://togithub.com/FakerPHP/Faker/pull/663) - Fix for polish street names + more polish TLDs by [@​tomaszklim](https://togithub.com/tomaszklim) in [https://github.com/FakerPHP/Faker/pull/664](https://togithub.com/FakerPHP/Faker/pull/664) - Fix psalm baseline in .gitattributes by [@​VincentLanglet](https://togithub.com/VincentLanglet) in [https://github.com/FakerPHP/Faker/pull/674](https://togithub.com/FakerPHP/Faker/pull/674) - composer(deps): bump rector/rector from 0.17.2 to 0.17.7 in /vendor-bin/rector by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/676](https://togithub.com/FakerPHP/Faker/pull/676) - composer(deps): bump phpstan/phpstan from 1.10.22 to 1.10.26 in /vendor-bin/phpstan by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/677](https://togithub.com/FakerPHP/Faker/pull/677) - composer(deps): bump friendsofphp/php-cs-fixer from 3.20.0 to 3.22.0 in /vendor-bin/php-cs-fixer by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/679](https://togithub.com/FakerPHP/Faker/pull/679) - composer(deps): bump vimeo/psalm from 5.13.1 to 5.14.1 in /vendor-bin/psalm by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/678](https://togithub.com/FakerPHP/Faker/pull/678) - chore: ensure php 8.3 compatibility by [@​Chris53897](https://togithub.com/Chris53897) in [https://github.com/FakerPHP/Faker/pull/684](https://togithub.com/FakerPHP/Faker/pull/684) - Remove invalid postcode pattern for France by [@​ker0x](https://togithub.com/ker0x) in [https://github.com/FakerPHP/Faker/pull/683](https://togithub.com/FakerPHP/Faker/pull/683) - Fix: Allow tests to fail on PHP 8.3 by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/693](https://togithub.com/FakerPHP/Faker/pull/693) - Fix: Test does not perform any assertions by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/695](https://togithub.com/FakerPHP/Faker/pull/695) - Fix: Operator by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/696](https://togithub.com/FakerPHP/Faker/pull/696) - Fix: Use boolean expressions by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/697](https://togithub.com/FakerPHP/Faker/pull/697) - composer(deps): bump rector/rector from 0.17.7 to 0.18.1 in /vendor-bin/rector by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/688](https://togithub.com/FakerPHP/Faker/pull/688) - composer(deps): bump phpstan/phpstan from 1.10.26 to 1.10.32 in /vendor-bin/phpstan by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/689](https://togithub.com/FakerPHP/Faker/pull/689) - composer(deps): bump vimeo/psalm from 5.14.1 to 5.15.0 in /vendor-bin/psalm by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/687](https://togithub.com/FakerPHP/Faker/pull/687) - composer(deps): bump phpstan/phpstan-deprecation-rules from 1.1.3 to 1.1.4 in /vendor-bin/phpstan by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/690](https://togithub.com/FakerPHP/Faker/pull/690) - composer(deps): bump friendsofphp/php-cs-fixer from 3.22.0 to 3.25.0 in /vendor-bin/php-cs-fixer by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/686](https://togithub.com/FakerPHP/Faker/pull/686) - Fix: Require to pass name to `ContainerBuilder::add()` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/702](https://togithub.com/FakerPHP/Faker/pull/702) - Enhancement: Run tests in random order by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/701](https://togithub.com/FakerPHP/Faker/pull/701) - Fix: Add property type declarations by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/699](https://togithub.com/FakerPHP/Faker/pull/699) - Fix: Enable and configure `type_declaration_spaces` instead of deprecated `function_typehint_space` fixer by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/698](https://togithub.com/FakerPHP/Faker/pull/698) - composer(deps): bump phpstan/phpstan from 1.10.32 to 1.10.33 in /vendor-bin/phpstan by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/704](https://togithub.com/FakerPHP/Faker/pull/704) - composer(deps): bump friendsofphp/php-cs-fixer from 3.25.0 to 3.25.1 in /vendor-bin/php-cs-fixer by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/705](https://togithub.com/FakerPHP/Faker/pull/705) - github-actions(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/FakerPHP/Faker/pull/706](https://togithub.com/FakerPHP/Faker/pull/706) - Fix: Switch order of parameters by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/703](https://togithub.com/FakerPHP/Faker/pull/703) - Fix: Remove unused method by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/711](https://togithub.com/FakerPHP/Faker/pull/711) - Fix: Rename parameter by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/707](https://togithub.com/FakerPHP/Faker/pull/707) - Fix: Add parameter type declaration by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/710](https://togithub.com/FakerPHP/Faker/pull/710) - Fix: Order by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/712](https://togithub.com/FakerPHP/Faker/pull/712) - Enhancement: Reuse `NumberExtension` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/715](https://togithub.com/FakerPHP/Faker/pull/715) - Fix: Methods are instance methods by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/708](https://togithub.com/FakerPHP/Faker/pull/708) - Fix: Add property type declarations by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/713](https://togithub.com/FakerPHP/Faker/pull/713) - Fix: Reduce visibility by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/714](https://togithub.com/FakerPHP/Faker/pull/714) - Fix: Do not memoize invalid service by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/709](https://togithub.com/FakerPHP/Faker/pull/709) - Fix: Consistently describe experimental status by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/717](https://togithub.com/FakerPHP/Faker/pull/717) - Fix: Mark classes as experimental by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/716](https://togithub.com/FakerPHP/Faker/pull/716) - Fix: Mark class as `final` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/718](https://togithub.com/FakerPHP/Faker/pull/718) - Fix: Return string by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/726](https://togithub.com/FakerPHP/Faker/pull/726) - Fix: Order by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/722](https://togithub.com/FakerPHP/Faker/pull/722) - Fix: Avoid unnecessary imports by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/721](https://togithub.com/FakerPHP/Faker/pull/721) - Enhancement: Enable `self_static_accessor` fixer by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/728](https://togithub.com/FakerPHP/Faker/pull/728) - Fix: Cache for `friendsofphp/php-cs-fixer` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/729](https://togithub.com/FakerPHP/Faker/pull/729) - Fix: Add parameter type declarations by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/724](https://togithub.com/FakerPHP/Faker/pull/724) - Fix: Add tests for `Container` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/727](https://togithub.com/FakerPHP/Faker/pull/727) - Fix: Simplify by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/720](https://togithub.com/FakerPHP/Faker/pull/720) - updated polish license plates by [@​scybulski](https://togithub.com/scybulski) in [https://github.com/FakerPHP/Faker/pull/685](https://togithub.com/FakerPHP/Faker/pull/685) - Fix: Update `CHANGELOG.md` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/734](https://togithub.com/FakerPHP/Faker/pull/734) - Fix: Avoid useless tests for `ContainerBuilder` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/730](https://togithub.com/FakerPHP/Faker/pull/730) - Fix: Rename parameter by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/731](https://togithub.com/FakerPHP/Faker/pull/731) - Add changelog mention in review checklist by [@​bram-pkg](https://togithub.com/bram-pkg) in [https://github.com/FakerPHP/Faker/pull/735](https://togithub.com/FakerPHP/Faker/pull/735) - Enhancement: Allow creating `ContainerBuilder` with definitions for default extensions by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/732](https://togithub.com/FakerPHP/Faker/pull/732) - Fix: Reduce visibility by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/719](https://togithub.com/FakerPHP/Faker/pull/719) - Fix: Remove unused method by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/736](https://togithub.com/FakerPHP/Faker/pull/736) - Enhancement: Add `SECURITY.md` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/739](https://togithub.com/FakerPHP/Faker/pull/739) - Fix: Do not use `static` in callables by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/785](https://togithub.com/FakerPHP/Faker/pull/785) - Fixed incorrect female name among male names ([#​794](https://togithub.com/FakerPHP/Faker/issues/794)) by [@​pimjansen](https://togithub.com/pimjansen) in [https://github.com/FakerPHP/Faker/pull/795](https://togithub.com/FakerPHP/Faker/pull/795) - Removed suppressed State from it_IT by [@​BoGnY](https://togithub.com/BoGnY) in [https://github.com/FakerPHP/Faker/pull/802](https://togithub.com/FakerPHP/Faker/pull/802) - Update Address.php to fix country name errors by [@​supgeek-rod](https://togithub.com/supgeek-rod) in [https://github.com/FakerPHP/Faker/pull/809](https://togithub.com/FakerPHP/Faker/pull/809) - fix [#​832](https://togithub.com/FakerPHP/Faker/issues/832) by [@​gam6itko](https://togithub.com/gam6itko) in [https://github.com/FakerPHP/Faker/pull/836](https://togithub.com/FakerPHP/Faker/pull/836) - Fix: Do not use deprecated `MT_RAND_PHP` constant on PHP 8.3 by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/844](https://togithub.com/FakerPHP/Faker/pull/844) - Enhancement: Prepare release for `1.23.1` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/788](https://togithub.com/FakerPHP/Faker/pull/788) - Fix: Remove branch alias for `1.23` by [@​localheinz](https://togithub.com/localheinz) in [https://github.com/FakerPHP/Faker/pull/843](https://togithub.com/FakerPHP/Faker/pull/843) #### New Contributors - [@​ivastly](https://togithub.com/ivastly) made their first contribution in [https://github.com/FakerPHP/Faker/pull/660](https://togithub.com/FakerPHP/Faker/pull/660) - [@​edgarsn](https://togithub.com/edgarsn) made their first contribution in [https://github.com/FakerPHP/Faker/pull/661](https://togithub.com/FakerPHP/Faker/pull/661) - [@​vintagesucks](https://togithub.com/vintagesucks) made their first contribution in [https://github.com/FakerPHP/Faker/pull/670](https://togithub.com/FakerPHP/Faker/pull/670) - [@​tomaszklim](https://togithub.com/tomaszklim) made their first contribution in [https://github.com/FakerPHP/Faker/pull/664](https://togithub.com/FakerPHP/Faker/pull/664) - [@​VincentLanglet](https://togithub.com/VincentLanglet) made their first contribution in [https://github.com/FakerPHP/Faker/pull/674](https://togithub.com/FakerPHP/Faker/pull/674) - [@​Chris53897](https://togithub.com/Chris53897) made their first contribution in [https://github.com/FakerPHP/Faker/pull/684](https://togithub.com/FakerPHP/Faker/pull/684) - [@​BoGnY](https://togithub.com/BoGnY) made their first contribution in [https://github.com/FakerPHP/Faker/pull/802](https://togithub.com/FakerPHP/Faker/pull/802) - [@​supgeek-rod](https://togithub.com/supgeek-rod) made their first contribution in [https://github.com/FakerPHP/Faker/pull/809](https://togithub.com/FakerPHP/Faker/pull/809) - [@​gam6itko](https://togithub.com/gam6itko) made their first contribution in [https://github.com/FakerPHP/Faker/pull/836](https://togithub.com/FakerPHP/Faker/pull/836) **Full Changelog**: FakerPHP/Faker@v1.23.0...v1.23.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/RadioRoster/backend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
Review checklist