Enhancement: Merge 1.23 into 2.0

CHANGELOG.md

@@ -6,6 +6,7 @@
 - Removed legacy autoloader (#762)
 - Removed functionality for populating ORM entities and models (#764)
 - Added a PHP version support policy (#752)
+- Stopped using `static` in callables in `Provider\pt_BR\PhoneNumber` (#785)
 
 ## [2023-06-12, v1.23.0](https://github.com/FakerPHP/Faker/compare/v1.22.0..v1.23.0)
 

src/Provider/pt_BR/PhoneNumber.php

@@ -83,7 +83,7 @@ public static function phone($formatted = true)
             ['landline', null],
         ]);
 
-        return call_user_func("static::{$options[0]}", $formatted, $options[1]);
+        return call_user_func([static::class, $options[0]], $formatted, $options[1]);
     }
 
     /**
@@ -135,7 +135,7 @@ public function phoneNumber()
     {
         $method = static::randomElement(['cellphoneNumber', 'landlineNumber']);
 
-        return call_user_func("static::$method", true);
+        return call_user_func([static::class, $method], true);
     }
 
     /**
@@ -145,6 +145,6 @@ public static function phoneNumberCleared()
     {
         $method = static::randomElement(['cellphoneNumber', 'landlineNumber']);
 
-        return call_user_func("static::$method", false);
+        return call_user_func([static::class, $method], false);
     }
 }

test/Provider/pt_BR/PhoneNumberTest.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Faker\Test\Provider\pt_BR;
+
+use Faker\Provider;
+use Faker\Test;
+
+/**
+ * @covers \Faker\Provider\pt_BR\PhoneNumber
+ */
+final class PhoneNumberTest extends Test\TestCase
+{
+    public function testPhoneReturnsPhoneNumberWhenArgumentIsFalse(): void
+    {
+        $phoneNumber = $this->faker->phone(false);
+
+        self::assertIsString($phoneNumber);
+        self::assertNotEmpty($phoneNumber);
+    }
+
+    public function testPhoneReturnsPhoneNumberWhenArgumentIsTrue(): void
+    {
+        $phoneNumber = $this->faker->phone(true);
+
+        self::assertIsString($phoneNumber);
+        self::assertNotEmpty($phoneNumber);
+    }
+
+    public function testPhoneNumberReturnsPhoneNumber(): void
+    {
+        $phoneNumber = $this->faker->phoneNumber();
+
+        self::assertIsString($phoneNumber);
+        self::assertNotEmpty($phoneNumber);
+    }
+
+    public function testPhoneNumberClearedReturnsPhoneNumber(): void
+    {
+        $phoneNumber = $this->faker->phoneNumberCleared();
+
+        self::assertIsString($phoneNumber);
+        self::assertNotEmpty($phoneNumber);
+    }
+
+    protected function getProviders(): iterable
+    {
+        yield new Provider\pt_BR\PhoneNumber($this->faker);
+    }
+}