Refactor of CONTRIBUTING.md #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Dec 1, 2020
|
Something seems up with the national insurance stuff. Either we have flakey generation, or a flakey test? |
|
I have no clue, as you can see nothing regarding that has changed and it's passing on main. Running again has seemed to fix it, so definitely inconsistent tests. |
|
I found the cause, it's not the bank account numbers, it's the new test for |
|
I raised a bug for this to review since it is not consistent it seems |
|
Issue with the test is fixed in main. @GrahamCampbell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
The contribution guide was quite outdates, I have updated links and rewritten parts that refer to documenting in the
README.md.Review checklist