Support auto skeleton item size calculation. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @puppywang, thank you for your contribution! This improvement makes absolute sense and I will gladly add it to the library. Sadly your pull request does not work as expected yet. The demo app shows only one item at a time in its Skeleton as opposed to the three items that would have place. Maybe you can test this by yourself and improve your pull request. Precondition: Set the skeletonItemSize of the RecyclerViewFragment to 0 in order to autocalculate the item count with your logic. Thanks in advance and have a nice day! |
|
Got, I will try to fix it ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our real app usage, we would like not to supply the skeleton item size in RecyclerView.applySkeleton, we want it automatically calculated, so I create this simple PR, please check, thanks.