Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller crash #278

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Fix controller crash #278

merged 7 commits into from
Jan 16, 2025

Conversation

tkmcmaster
Copy link
Collaborator

@tkmcmaster tkmcmaster commented Jan 15, 2025

Coverage:
image
image

- If running in AWS we still create a single s3 or sqs client that gets returned, but the config now is a function that returns that client
- If not running in AWS, we create an s3 or sqs client each time we need it and use the fromIni to not cached the credentials
- mock.ts now creates it's own mock instance and then creates an override function for the s3 or sqs config to return the mocked client
- On test status with large console errors, we were loading the whole thing server side and it was crashing the server
- Changed to lazy load it client-side and call the API rather than process it all server-side
@tkmcmaster tkmcmaster requested review from bryan-e-lopez and a team January 15, 2025 22:19
@tkmcmaster tkmcmaster self-assigned this Jan 15, 2025
@tkmcmaster tkmcmaster merged commit b32cb72 into master Jan 16, 2025
3 checks passed
@tkmcmaster tkmcmaster deleted the fix-controller-crash branch January 16, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants