fix(fa-surface): Use the transclude function from post #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaiat
force-pushed
the
fix-surface-transclude
branch
from
d461f89
to
11139ed
Compare
|
As surface is a leaf node, this change should not have any side effect. I'm not sure if same fix should be done across all directives... Let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per angular documentation, the usage of the transclude function from compile has been deprecated in angular 1.3 (started 1.2 I believe).
One should only use
transcludeprovided as the 5th argument ofpreorpostfunction to make sure the scope is correct.For more info : angular/angular.js#9413