Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CancellationToken parameters must come last #482

Closed
FantasticFiasco opened this issue Sep 5, 2021 · 0 comments · Fixed by #542
Closed

CancellationToken parameters must come last #482

FantasticFiasco opened this issue Sep 5, 2021 · 0 comments · Fixed by #542
Labels
enhancement New feature or request

Comments

@FantasticFiasco
Copy link
Owner

According to CA1068 the cancellation token must come last. This would be applicable to both private/internal and public methods.

Since this is a breaking change, we will have to wait with fixing this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CancellationToken parameters must come last FantasticFiasco/aws-signature-version-4
1 participant
@FantasticFiasco