Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetStandard 1.3 and csproj migration #7

Closed
scottamartin opened this issue Apr 7, 2017 · 6 comments · Fixed by #8
Closed

NetStandard 1.3 and csproj migration #7

scottamartin opened this issue Apr 7, 2017 · 6 comments · Fixed by #8

Comments

@scottamartin
Copy link
Contributor

Step 1: Describe your environment

  • Develop on OS X and Windows
  • Run code on Windows and Ubuntu

Step 2: Describe the problem

I would like to migrate the project to the new csproj format and downgrade the NetStandard reference to 1.3 to match Serilog. From what I can tell 1.3 is the lowest this library could use due to needing System.Net.Sockets.
@FantasticFiasco
Copy link
Owner

Hi scottamartin!

That would be a fantastic contribution. I assume that also would include migrating solution file to VS2017?

@scottamartin
Copy link
Contributor Author

scottamartin commented Apr 7, 2017 •
edited
Loading

Yes, that is correct. As far as the build script goes, I would would need to update the image for AppVeyor to VS2017 and that would allow for the removal of the "install" portion.

@FantasticFiasco
Copy link
Owner

Removing code is my favorite type of implementation, just knock yourself out.

And again, thanks for the time and effort you put into this.

@FantasticFiasco
Copy link
Owner

How is the code treating you, are encountering any problems in the migration? If you desire I can team up with you and help you push this code to production.

@scottamartin
Copy link
Contributor Author

Everything is going well, I ran into a larger than normal workload this week. The "dotnet migration" tool is not working, so I am manually converting the project to csproj. I am going to try and devote some time to this today and over this weekend.

scottamartin added a commit to scottamartin/serilog-sinks-udp that referenced this issue Apr 13, 2017
@scottamartin
__feat__: Migrate project to csproj
7579a1b 
- Downgrade from netstandard1.5 to netstandard1.3
- Clean up build warnings in the csproj files

Closes FantasticFiasco#7
@scottamartin scottamartin mentioned this issue Apr 13, 2017
Merged
@scottamartin
Copy link
Contributor Author

scottamartin commented Apr 13, 2017 •
edited
Loading

@FantasticFiasco PR has been submitted, let me know if you see anything. I am able to run the build and tests on my windows machine (cmd line and Visual Studio 2017). I am also able to restore, build, and test on my mac using the "-f netstandard1.3" flag to specify the framework.

If you can build a dev package, I would be glad to test this in my current projects.

scottamartin added a commit to scottamartin/serilog-sinks-udp that referenced this issue Apr 14, 2017
@scottamartin
feat: Migrate project to csproj
27f2c5c 
- feat: downgrade from netstandard1.5 to netstandard1.3 and convert project to csproj
- chore: clean up build warnings in the csproj files
- chore: Update appveyor.yml image Visual Studio 2017 and remove install steps to install dotnet cli
- chore: update package information
- chore: remove assembly info generation from csproj
- docs(changelog): update
- chore: update csproj to not reference entire netstandard and reference System.Net.Sockets for netstandard1.3
- chore: treat warnings as errors

closes FantasticFiasco#7
FantasticFiasco pushed a commit that referenced this issue Apr 14, 2017
@scottamartin @FantasticFiasco
feat: Migrate project to csproj
ff296b1 
- feat: downgrade from netstandard1.5 to netstandard1.3 and convert project to csproj
- chore: clean up build warnings in the csproj files
- chore: Update appveyor.yml image Visual Studio 2017 and remove install steps to install dotnet cli
- chore: update package information
- chore: remove assembly info generation from csproj
- docs(changelog): update
- chore: update csproj to not reference entire netstandard and reference System.Net.Sockets for netstandard1.3
- chore: treat warnings as errors

closes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Migrate project to csproj scottamartin/serilog-sinks-udp
2 participants
@scottamartin @FantasticFiasco