Cancun eth tests #1135
Cancun eth tests #1135
Conversation
… inside eth-tests; Call Carmens SelfDestruct6780;
# Conflicts: # ethtest/block_enviroment.go # executor/transaction_processor.go # go.mod # go.sum # txcontext/block_environment.go # txcontext/substate/block_environment.go
cabrador
requested review from
wsodsong and
HerbertJordan
and removed request for
wsodsong
There was a problem hiding this comment.
This is a huge PR that would have benefited from being decomposed into multiple smaller PRs. For instance, the change of the GetDirectoryFiles function now accepting a list of paths could be on its own. So could be the introduction of the chain configuration in the block environment.
Smaller, focused PRs pay off in improving the review process, and thus leading to better results in my experience.
Another observation is that for all those new features being added, very little unit tests are present covering those.
I can mostly provide feedback on coding style and a few additional observations. I think @wsodsong should make the final approval decision.
| // GetChainConfig returns current setup for ChainConfig. | ||
| GetChainConfig() *params.ChainConfig | ||
|
|
||
| // GetRandom returns the random hash. |
There was a problem hiding this comment.
What is "the" random hash? Just "a" random hash generated right at the spot or something more restricted?
There was a problem hiding this comment.
I actually dont know. The documentation is very limited but its used for creating Mixhash in genesis
There was a problem hiding this comment.
Random is from Block context https://github.com/ethereum/go-ethereum/blob/8032b63f167938e6441d4be3eb49b12014d9bfc8/core/vm/evm.go#L67
I don't fully know how it works, but it has to do with mining diffuculty. It is not a random number.
# Conflicts: # ethtest/open.go # executor/rpc_request_provider.go # utils/directory.go
# Conflicts: # ethtest/block_enviroment.go # ethtest/open.go # ethtest/result.go # ethtest/state_test_context.go # ethtest/test_case_splitter.go # ethtest/test_case_splitter_test.go
| // GetChainConfig returns current setup for ChainConfig. | ||
| GetChainConfig() *params.ChainConfig | ||
|
|
||
| // GetRandom returns the random hash. |
There was a problem hiding this comment.
Random is from Block context https://github.com/ethereum/go-ethereum/blob/8032b63f167938e6441d4be3eb49b12014d9bfc8/core/vm/evm.go#L67
I don't fully know how it works, but it has to do with mining diffuculty. It is not a random number.
cabrador
force-pushed
the
petr/cancun-eth-tests
branch
from
2cae2ea
to
e345a83
Compare
cabrador
force-pushed
the
petr/cancun-eth-tests
branch
from
e3288ac
to
70deec1
Compare
Description
This PR adds creating
BlockContextbefore transaction execution and allows passing dynamicChainConfigto transaction execution.Both of these new features are necessary by
Cancuntests insideeth-tests.TODO:
Type of change