-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] --substate-encoding flag to switch between rlp/others #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabrador
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all the work on protobuf
!
rpl-ffl
force-pushed
the
rapol/feature/flag-switch-rlp-pb
branch
from
September 25, 2024 11:06
5d5339e
to
20ee4b9
Compare
cabrador
requested changes
Sep 26, 2024
rpl-ffl
force-pushed
the
rapol/feature/flag-switch-rlp-pb
branch
from
September 26, 2024 08:56
cc5466d
to
a3ba2f8
Compare
rpl-ffl
force-pushed
the
rapol/feature/flag-switch-rlp-pb
branch
from
September 26, 2024 09:00
a3ba2f8
to
b49cf9e
Compare
wsodsong
previously approved these changes
Sep 26, 2024
matejmode
reviewed
Sep 26, 2024
matejmode
previously approved these changes
Sep 26, 2024
rpl-ffl
changed the title
[Feature] --substate-encoding flag to switch between rlp/protobuf
[Feature] --substate-encoding flag to switch between rlp/others
Sep 27, 2024
cabrador
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments. Otherwise LGTM!
cabrador
approved these changes
Sep 27, 2024
rpl-ffl
added a commit
that referenced
this pull request
Sep 27, 2024
* add --substate-encoding flag * syntax error fix in flags * add --substate-encoding to aida-vm * SetDecoder->SetSubstateEncoding * update Substate to access SubstateEncoding * default->rlp * error handling for SetSubstateEncoding * lower case error
rpl-ffl
added a commit
that referenced
this pull request
Sep 28, 2024
* add --substate-encoding flag * syntax error fix in flags * add --substate-encoding to aida-vm * SetDecoder->SetSubstateEncoding * update Substate to access SubstateEncoding * default->rlp * error handling for SetSubstateEncoding * lower case error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in anticipation of the following change in substate: Fantom-foundation/Substate#86.Aida can now select between rlp/protobuf when decoding from disk using the flag
--substate-encoding
.The flag defaults to "default" -> which defaults to rlp.
Currently effective only for
aida-vm
.Example usage:
Type of change