Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datadir symlinks cache #520

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Datadir symlinks cache #520

wants to merge 5 commits into from

Conversation

rus-alex
Copy link
Contributor

Datadir size measurement is ~7 times faster with cached filepath.EvalSymlinks().

Benchmark results (see ./cmd/opera/launcher/metrics/metrics_test.go) of 400Gb datadir:

ns per op bytes per op allocs per op
Before: 28363077808 13015784248 156690205
After: 4823172318 1477883992 11329437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrecronje andrecronje Awaiting requested review from andrecronje andrecronje is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@uprendis uprendis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rus-alex @uprendis