Making Entry Model swappable using django-swappable-models. #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* With this change, there is no need for the app extending
Entry model to provide workarounds like MIGRATION_MODULES
or ZINNIA_ENTRY_BASE_MODEL.
* The app just needs to make a dependency in the migration
to zinnia by adding
('zinnia', '0001_initial'),
to depencies section in the generated migration. After that
first zinnia:0001_initial migration is run, followed by
the migration generated in the app extending the Entry model.
And then rest of the migrations defined in zinnia/migrations/
are run.
This way the migrations are generated in the correct place.
* The load_model_class is now not being used.
* The user can define the ZINNIA_ENTRY_MODEL = 'myblog.Entry'
to swap his/her own Entry model with default zinnia's Entry
model with the swapped model extending from AbstractEntry
model or can define his/her own AbstractEntry model and
extend from that model. Only redefining AbstractEntry model
is not sufficient. If one is redefining AbstractEntry model,
then he/she also needs to define his/her own Entry model
which needs to be swapped. This is because changing the
AbstractEntry only changes the schema for the default
Entry model and thus when generating migration, they are
generated by default in zinnia's own migrations folder.
Summary:
-- If you simply want to add extra fields to Entr model,
then simply define ZINNIA_ENTRY_MODEL = 'myblog.Entry'
in settings, and define Entry model with additional
fields. Run makemigrations and set dependency on
zinnia_0001 in generated migration. The migration
is generated in your own app and not in zinnia
and the dependencies are properly set.
-- If you want to override some of the fields defined
in AbstractEntry, then redefine it in your models,
and also define your Entry model extending from this
AbstractEntry. And follow rest of the instructions
in step1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of your pull request?
correctly run. There is even no need to define the ENTRY_BASE_MODEL as this change obviates the need for doing that.
Proposed changes
Warning
Before submitting a pull request make sure you have: