Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register PointMaze_Open_Diverse_GR #195

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

dtch1997
Copy link
Contributor

Description

Registers the PointMaze_Open_Diverse_GR environment.

Fixes #194

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodrigodelazcano do we want to add environments versions without a version bump?

},
kwargs,
),
max_episode_steps=300,
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300 time steps is the same as OPEN_DIVERSE_G (which is good)

@Kallinteris-Andreas
Copy link
Collaborator

Also, would like to point out that, maps.EMPTY_MAZE is not used for neither PointMaze nor AntMaze

EMPTY_MAZE = [
[1, 1, 1, 1, 1],
[1, 0, 0, 0, 1],
[1, 1, 1, 0, 1],
[1, 0, 0, 0, 1],
[1, 1, 1, 1, 1],
]

@Kallinteris-Andreas
Copy link
Collaborator

@dtch1997 please run the pre-commit checks

@dtch1997
Copy link
Contributor Author

Hi @Kallinteris-Andreas thanks for getting back to me on the PR.

I believe the failing pre-commit check is unrelated to my changes. Looking at the stack trace, the pyright failures appear to be due to this file:
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py

I do not know how to fix these issues.

Full stack trace from here:

typeshedPath /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/typeshed is not a valid directory.
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py
  /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:277:24 - error: "mujoco" is possibly unbound (reportUnboundVariable)
  /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:278:23 - error: "mujoco_utils" is possibly unbound (reportUnboundVariable)
  /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:308:9 - error: "mujoco" is possibly unbound (reportUnboundVariable)
  /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:355:27 - error: "mujoco_py" is possibly unbound (reportUnboundVariable)
  /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:356:23 - error: "mujoco_py_utils" is possibly unbound (reportUnboundVariable)

@Kallinteris-Andreas
Copy link
Collaborator

@dtch1997 does it pass pre-commit on your computer?

I am looking into the CI issues

@dtch1997
Copy link
Contributor Author

@Kallinteris-Andreas No, I have the same error when running the linters locally.

$ pre-commit run --all-files
black....................................................................Passed
codespell................................................................Passed
flake8...................................................................Passed
isort....................................................................Passed
pyupgrade................................................................Passed
pyright..................................................................Failed
- hook id: pyright
- exit code: 1

typeshedPath /home/daniel/Documents/github/Gymnasium-Robotics/typeshed is not a valid directory.
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py
  /home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:277:24 - error: "mujoco" is possibly unbound (reportUnboundVariable)
  /home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:278:23 - error: "mujoco_utils" is possibly unbound (reportUnboundVariable)
  /home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:308:9 - error: "mujoco" is possibly unbound (reportUnboundVariable)
  /home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:355:27 - error: "mujoco_py" is possibly unbound (reportUnboundVariable)
  /home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:356:23 - error: "mujoco_py_utils" is possibly unbound (reportUnboundVariable)
5 errors, 0 warnings, 0 informations

@Kallinteris-Andreas Kallinteris-Andreas merged commit 055be6a into Farama-Foundation:main Dec 23, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] PointMaze_Open_DiverseGR not registered
2 participants