Dynamically determine highlighting in RGBImgObsWrapper
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pseudo-rnd-thoughts
requested changes
Aug 1, 2023
minigrid/wrappers.py
Outdated
| @@ -323,7 +323,7 @@ def __init__(self, env, tile_size=8): | |||
| ) | |||
|
|
|||
| def observation(self, obs): | |||
| rgb_img = self.get_frame(highlight=True, tile_size=self.tile_size) | |||
| rgb_img = self.get_frame(highlight=self.env.highlight, tile_size=self.tile_size) | |||
There was a problem hiding this comment.
If wrappers can't modify this value, could you use self.unwrapped.highlight as if self.env is not the base environment, this will break in Gymnasium v1.0.0
There was a problem hiding this comment.
Done.
I also changed self.env.height and self.env.width to use self.unwrapped, a few lines up.
pseudo-rnd-thoughts
approved these changes
Aug 1, 2023
pseudo-rnd-thoughts
changed the title
highlighting in RGBImgObsWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
observationmethod ofRGBImgObsWrappersuch that the agent field-of-view (FOV) highlight is rendered only when the underlying environment has this enabled with thehighlightbool. (default True). Previously the FOV highlighting was hardcoded to always be enabled, regardless of whathighlightwas.Fixes #382, #326
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)