Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py for gym v0.21 #82

Closed
wants to merge 1 commit into from

Conversation

pseudo-rnd-thoughts
Copy link
Member

For "gym-v21", the installation is "gym>=0.21" however this allows gym==0.26 to be installed, failing the exact case.

Additionally, we could look to add the same requirements as specified in openai/gym#3211

For "gym-v21", the installation is "gym>=0.21" however this allows gym==0.26 to be installed, failing the exact case. 

Additionally, we could look to add the same requirements as specified in openai/gym#3211
@elliottower
Copy link
Contributor

Not sure what the best course of action is, but looking through those issues it looks like we may have to add other requirements for v21? openai/gym#3202 (comment)

opencv-python>=3
wheel==0.38.4
pip install setuptools == 66 (you posted this but not sure if this is even possible via pip cause it's a setup.py thing)

@pseudo-rnd-thoughts
Copy link
Member Author

Additionally, we should probably have separate tests for gym == 0.26 and == 0.21

@elliottower
Copy link
Contributor

elliottower commented May 15, 2023 via email

@elliottower
Copy link
Contributor

Looks like these changes prevented pip install shimmy[all, testing] from working, not sure how to get around that though

@pseudo-rnd-thoughts
Copy link
Member Author

I think in shimmy we are going to need a gym v26 test and a gym v21 test.
In all tests then we can use testing environments not from gym.make for the v21 case.

@elliottower
Copy link
Contributor

elliottower commented May 20, 2023 via email

@elliottower elliottower mentioned this pull request May 24, 2023
7 tasks
@elliottower elliottower deleted the pseudo-rnd-thoughts-patch-1 branch October 17, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants