Change usages of reset() to obs, info = reset() #214
Conversation
# Conflicts: # supersuit/multiagent_wrappers/black_death.py
| @@ -183,6 +183,7 @@ def reset(self, seed=None, options=None): | |||
|
|
|||
There was a problem hiding this comment.
Don't know much about how this wrapper works but it seems to pass the tests despite only returning the observation, so maybe it's fine. Didn't try adding info but could in the future if we want everything to be consistent (this was one of only cases left of not returning info)
There was a problem hiding this comment.
I looked at the git blame and I believe there was never any returning of info in this function
| @@ -14,7 +14,9 @@ def reset(self, seed=None, options=None): | |||
| return self.venv.reset() | |||
|
|
|||
| def step_wait(self): | |||
| return self.venv.step_wait() | |||
| obss, rews, terms, truncs, infos = self.venv.step_wait() | |||
There was a problem hiding this comment.
This change wasn't intentional, I think it must have been due to using an older version of master. I'm going to try removing it and seeing if the tests pass still
There was a problem hiding this comment.
Just removed it, will check back if it passed later
There was a problem hiding this comment.
CI passed but we don't have CI testing it with SB3, and looking at the docs they are keeping the old gym v21 API with done instead of truncations/terminations, so I'm going to keep this.
https://stable-baselines3.readthedocs.io/en/master/guide/vec_envs.html
|
If you look at the 'disable gen env tests which fail' CI the only thing that fails is pre-commit |
This PR fixes a number of issues with both PettingZoo and current Gymnasium versions. Much of the code in SuperSuit uses
obs = env.reset()rather thanobs, info = env.reset(), so I had to adapt things to work.