ProcConcatVec close fix #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ProcConcatVec's subprocesses are not being terminated when the environment is closed. Instead, they are only terminated when ProcConcatVec is garbage collected. This is a problem as the subprocesses cannot be explicitly terminated, and if the client accidentally holds on to a reference to ProcConcatVec, the child processes will never be terminated. According to the Gymnasium documentation, the close method should be responsible for releasing all of the environment's resources. This commit fixes the issue by terminating the subprocesses on close. The graceful shutdown period controls the number of seconds to wait for the subprocess environments to terminate before killing them. It is set to None by default, meaning that close will block until all subprocesses terminate on their own. __del__ in ProcConcatVec has been removed as its parent class VectorEnv already delegates to close in its __del__. The terminate instruction has been removed from the subprocess event loop as it is now redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code from #208 to work with the current master branch. I independently found that the ProcConcatVec env didn't close and couldn't figure out the solution myself, but found this PR from a few months ago seems to address it. Running CI to see if it works now.