Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render method with same signature as SB3 underlying class #228

Merged

Conversation

elliottower
Copy link
Contributor

This PR fixes the render() method not matching the signature as SB3's VecEnvWrapper class, fixing #223

@elliottower
Copy link
Contributor Author

This doesn't affect anything really, it just allows you to use the proper syntax that SB3 expects, and if you happen to have ansi or rgb_array as your underlying render_mode and your environment's render method is defined to return a value, then that will be returned to SB3, otherwise nothing happens.

@elliottower elliottower merged commit cbeeec2 into Farama-Foundation:master Jul 20, 2023
@elliottower elliottower deleted the fix-SB3-wrapper-render branch July 20, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant