refactor!: refactor the IMessageContext to a more concise structure #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougolima
suggested changes
Apr 27, 2021
filipeesch
force-pushed
the
context-impro
branch
3 times, most recently
from
7673c29 to
f8b76df
Compare
filipeesch
changed the title
filipeesch
force-pushed
the
context-impro
branch
from
f8b76df to
0c7118b
Compare
- The Transform method now creates a new MessageContext containing the new Message - The middlewares executor do not clone the MessageContext any more - Renames the MessageContextConsumer to ConsumerContext and all information about the consumer and consumed message metadata is stored there - Creates the ProducerContext and all information about the producer and produced message metadata is stored there
filipeesch
force-pushed
the
context-impro
branch
from
0c7118b to
eb383ab
Compare
dougolima
approved these changes
Apr 28, 2021
filipeesch
force-pushed
the
context-impro
branch
2 times, most recently
from
41f818e to
9be095a
Compare
dougolima
suggested changes
Apr 28, 2021
src/KafkaFlow.Serializer.SchemaRegistry.ConfluentAvro/ConfluentAvroSerializer.cs
Outdated
Show resolved
Hide resolved
filipeesch
force-pushed
the
context-impro
branch
from
9be095a to
f2f19f4
Compare
filipeesch
force-pushed
the
context-impro
branch
from
f2f19f4 to
a93aa26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #103
How Has This Been Tested?
The integration and unit tests were executed
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement