feat!: change the serializers to use async and streams #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeesch
force-pushed
the
async-serializers
branch
2 times, most recently
from
cf8df0f to
0455c9a
Compare
dougolima
suggested changes
Apr 30, 2021
- The IMessageSerializer was renamed to ISerializer - The method Serialize was changed to SerializeAsync, to return a Task and writing the result into a Stream - The method Deserialize was changed to DeserializeAsync, to return a Task and read the data from a Stream - All the existing serializer was changed to use the new interface
filipeesch
force-pushed
the
async-serializers
branch
from
0455c9a to
8871301
Compare
dougolima
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #142
How Has This Been Tested?
The Unit and Integration tests were executed
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement