Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: Kafkaflow does not allow to have consumers with different consumer groups #424

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

simaoribeiro
Copy link
Contributor

Description

ConsumerConfig was being referenced between consumers. This fix creates each consumer with ConsumerConfig in an isolated way.

Fixes # (issue)

fix #410

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

@simaoribeiro simaoribeiro changed the title Issue 410 [Bug Report]: Kafkaflow does not allow to have consumers with different consumer groups Sep 5, 2023
Copy link
Contributor

@brmagadutra brmagadutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simaoribeiro simaoribeiro merged commit 9ccfd35 into Farfetch:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants