fix: add Microsoft.Extensions.FileProviders.Embedded package #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruiqbarbosa
requested review from
joelfoliveira,
ailtonguitar,
lpcouto,
simaoribeiro,
brmagadutra and
JoaoRodriguesGithub
joelfoliveira
approved these changes
Dec 26, 2023
simaoribeiro
approved these changes
Dec 26, 2023
joelfoliveira
deleted the
fix/add-microsoft-extension-embedded-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The removal of
Microsoft.Extensions.FileProviders.Embeddedin MR-486 caused an exception for assembly 'KafkaFlow.Admin.Dashboard' when using the ManifestEmbeddedFileProvider to get the provider.This package has been added again in the current MR.
Fixes #497
How Has This Been Tested?
The dashboard project runs successfully without throwing any exceptions.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement