-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding oAuth #521
Adding oAuth #521
Conversation
This is going to clash with #495 |
Hello Diogo! Could you please fix the issues raised by the static code analysis? https://github.com/Farfetch/kafkaflow/pull/521/checks We're currently in the process of reviewing and testing this PR to go forward with it. Thank you! |
Hello Robert! Yes, the idea is to go forward with both of these PRs. We'll be validating the OAuth support first and then if everything is ok, we'll update documentation, add code samples (if needed) and then also test and go forward with your PR. 🙂 |
Hello Diogo! Could you please fix the commit message errors so we can merge this PR? Thanks! 🙂 |
feat: add oauth
1b3cc16
to
4d2a0e5
Compare
Description
Adding oAuth layer to communicate to confluent kafka.
Fixes # (issue)
#417
How Has This Been Tested?
Created a client and secret and tested with the same IDP configured in kafka.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement