Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oAuth #521

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Adding oAuth #521

merged 2 commits into from
Apr 3, 2024

Conversation

diogoabcosta89
Copy link
Contributor

Description

Adding oAuth layer to communicate to confluent kafka.

Fixes # (issue)

#417

How Has This Been Tested?

Created a client and secret and tested with the same IDP configured in kafka.

Checklist

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@robertcoltheart
Copy link
Contributor

This is going to clash with #495

@fasazevedo
Copy link
Contributor

Hello Diogo!

Could you please fix the issues raised by the static code analysis? https://github.com/Farfetch/kafkaflow/pull/521/checks

We're currently in the process of reviewing and testing this PR to go forward with it. Thank you!

@robertcoltheart
Copy link
Contributor

robertcoltheart commented Mar 21, 2024

Can we somehow merge this with #495 to support setting a token refresh handler? The use case is to be able to support AWS MSK IAM authentication which relies on this method.

Edit: I took the initiative and merged this PR to mine here: #495

@fasazevedo
Copy link
Contributor

Can we somehow merge this with #495 to support setting a token refresh handler? The use case is to be able to support AWS MSK IAM authentication which relies on this method.

Edit: I took the initiative and merged this PR to mine here: #495

Hello Robert!

Yes, the idea is to go forward with both of these PRs. We'll be validating the OAuth support first and then if everything is ok, we'll update documentation, add code samples (if needed) and then also test and go forward with your PR. 🙂

@fasazevedo
Copy link
Contributor

Hello Diogo!

Could you please fix the commit message errors so we can merge this PR?

Thanks! 🙂

feat: add oauth
@fasazevedo fasazevedo merged commit da4bfb7 into Farfetch:master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants