The future of GiftedChat 🎉

[xcarpentier]

Roadmap

• Rewriting into a functional component way
• Use more new context API (ie. locale and action sheet and hope more)
• Add more unit tests with react-native-testing-library
• Move all defaultProps into FC params const fn = ({ something = 42 }: Props) => { // ... }
• Refactor IMessage using TypeScript features like tag literals to determine type of message (ie. text, video, audio, image, system and also status: 'sent' | 'received' | 'read', ...)
• use recyclerListView (cc @myckhel)

Reviewers

Please I need to have some reviewers. 🙏

[danielmejiadev]

Well done

[danielmejiadev]

@xcarpentier would be great if you merge this PR, So we can continue with migration to functional components based on this.

My idea is migrate the current user into context API you built so, we avoid to pass user prop around the tree.

[xcarpentier]

Hi!
Another way will be to create a PR from this branch and I will merge it.
What do you think?

[danielmejiadev]

Hi
That seems great to me. So I'm gonna work on that and create the PR, so you could check it out.
Thank you.

[danielmejiadev]

@xcarpentier What did you say is necessary in order to merge this PR?

[xcarpentier]

@xcarpentier What did you say is necessary in order to merge this PR?

Please read the comment here
And if you have other ideas please share ;)

[danielmejiadev]

@xcarpentier
In order to complete the first item, should we rewrite all components to FC?
Would be great to implement sound and video message type. What do you say?

[xcarpentier]

@xcarpentier

In order to complete the first item, should we rewrite all components to FC?

Would be great to implement sound and video message type. What do you say?

It’s not the structural kind of improvement I suggest for this PR.

But I already think about GiftedChat components rendering and customization by a splitting it into small independent parts; with monorepo technic (lerna+workspace).

That will mean a core and plugin small components into it like message video, audio, etc.

Also I would like use build tool like tsdx for this project.

[ziyaddin]

Clipboard is being imported from react-native package, which is the outdated one, instead of @react-native-clipboard/clipboard, which is the latest one. Usage of the outdated one results in this warning:

Warning: Clipboard has been extracted from react-native core and will be removed in a future release.
It can now be installed and imported from '@react-native-clipboard/clipboard' instead of 'react-native'.
See https://github.com/react-native-clipboard/clipboard

react-native-gifted-chat/src/Bubble.tsx

Lines 3 to 12 in 6d93f4a

	import {
	Text,
	Clipboard,
	StyleSheet,
	TouchableWithoutFeedback,
	View,
	StyleProp,
	ViewStyle,
	TextStyle,
	} from 'react-native'

[Johan-dutoit]

If maintainer role can be given, alongside access to npm publishing, then progress can be made.
Alternatively- fork, update and release a new/independent chat library.

[Johan-dutoit]

I was looking at merging this PR, however at two years old, this rewrite will likely need additional changes.
Thoughts?

[Johan-dutoit]

With some minor changes (mostly test & lint fixes), I pushed the branch to npm with the next tag. I haven't tested this and will be doing so over the next couple of days.

I'll be taking whatever feedback is posted here, along with what I find during testing to decide the path forward with this branch.

[Johan-dutoit]

In case anyone wanted to know my thinking

• Merging this into master
• Renaming master to main
• Abandoning/closing old PR's that don't seems relevant
• Abandoning/closing issues that don't seems relevant
• Working with smaller changes

I'll likely action this in the next 24 hours or so, to allow time for challenges.

[jamonholmgren]

@Johan-dutoit Thank you for your work on this! I’ll be trying it out soon for an app I’m building.

[Johan-dutoit]

@Johan-dutoit Thank you for your work on this! I’ll be trying it out soon for an app I’m building.

Hah I'd love to take the credit @jamonholmgren, but I'm simply carrying @xcarpentier's work over the line.
Let me first make significant contributions before accepting too much praise 🤣

[myckhel]

@Johan-dutoit Thank you for your work on this! I’ll be trying it out soon for an app I’m building.

Hah I'd love to take the credit @jamonholmgren, but I'm simply carrying @xcarpentier's work over the line. Let me first make significant contributions before accepting too much praise 🤣

Carrying the work also worth the credits 👌

[adamalexander]

@xcarpentier
"use recyclerListView (cc @myckhel)"
or better yet; react-native-android-recyclerview for android.

[kesha-antonov]

Hi

I think we should give a try to https://github.com/shopify/flash-list