New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes null type for renderAvatar prop #2327

Merged

Johan-dutoit merged 1 commit into FaridSafi:master from lsthornt:fix-render-avatar-type

Jun 12, 2023

Contributor

lsthornt commented Jan 4, 2023

The renderAvatar prop must accept null as value to prevent issues like #2274.

null was included in the union type of the renderAvatar return value, and thus was not caught by this TS rule


          Fixes null type for renderAvatar prop

1fca709

Contributor Author

lsthornt commented Jan 19, 2023

Is it possible to re-run/remove the CI check? Looks like newer PRs are not facing this issue

mendrixsebas approved these changes

View reviewed changes

Johan-dutoit approved these changes

View reviewed changes

Johan-dutoit merged commit b66f373 into FaridSafi:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet