fixed: focus handling when opening keyboard #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with focus handling when opening the keyboard. I discovered that when an input field inside a modal on the chat page receives focus, the focus was incorrectly being intercepted by the chat input. The check for
isTextInputWasFocused: MutableRefObject<boolean>was incorrect, so it has been replaced with a value check.All tests have passed successfully. However, given my limited experience with this library, I would appreciate it if someone familiar with the project could review this change to ensure it doesn't unintentionally alter any critical behavior.
Let me know if you want any changes to it