Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firmware] Movements retry too many times #990

Open
gabrielburnworth opened this issue Sep 19, 2019 · 0 comments
Open

[Firmware] Movements retry too many times #990

gabrielburnworth opened this issue Sep 19, 2019 · 0 comments
Labels
bug

Comments

@gabrielburnworth
Copy link
Contributor

FarmBot OS version

8.0.2

Behavior

Movements are currently attempted n^2 + n times, where n is the number of retries selected by the user. FarmBot OS attempts a movement n + 1 times, and every time FarmBot OS tries a movement, the firmware attempts the movement n times.

Expected

The movement retry mechanism should only be implemented in (one of) the firmware or FarmBot OS.

Relevant code

farmbot_os/farmbot_os/lib/farmbot_os/sys_calls.ex

Line 279 in 923f024

do_move_absolute(x, y, z, speed, retries - 1, [reason | errors])

@ConnorRigby ConnorRigby changed the title Movements retry too many times [Firmware] Movements retry too many times Oct 31, 2019
RickCarlino added a commit that referenced this issue Feb 8, 2020
@RickCarlino
Possible fix for #990
c4f1cc3
@RickCarlino RickCarlino mentioned this issue Feb 10, 2020
Closed
@roryaronson roryaronson moved this to QA'd, Ready to Deploy in FarmBot Project Board Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
FarmBot Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make firmware (not FBOS) respnsible for retries FarmBot/farmbot_os
1 participant
@gabrielburnworth