-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe pricing table again #420
base: main
Are you sure you want to change the base?
Conversation
β Deploy Preview for storied-crostata-fa92db ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
β Deploy Preview for dreamy-paletas-cb5e15 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we're not ready to ship, but this looks really good!
Added a few thoughts + comments
@@ -18,92 +18,24 @@ | |||
</div> | |||
|
|||
<div class="row"> | |||
<div class="small-12 columns"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β Does removing this class do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember why I removed this specifically (likely faffing around with the pricing table width), though small-12
is just width: 100%
, so I think it only makes sense if you're setting different widths at different breakpoints, right? Otherwise the div
's width is always 100%.
<script async src="https://js.stripe.com/v3/pricing-table.js"></script> | ||
<stripe-pricing-table pricing-table-id="prctbl_1PYSAdHVcZRgX183ab67RI0g" | ||
publishable-key="pk_live_1sIaEOF4fdxq136517FMhqG0"> | ||
</stripe-pricing-table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: Do we need to do anything in case the Pricing Table doesn't load (for whatever reason)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good question. I didn't see anything in the Stripe documentation about it, so...no? It loads a custom element so we could check with something like
const pricingTableLoaded = !!customElements.get('stripe-pricing-table');
if (!pricingTableLoaded) {
// insert fallback
}
π¨ Don't merge this π π¨
β‘ THIS IS A LIVE TABLE β‘
If you purchase through this you will be charged actual real money. If you're keen to test, there's a discount code, which you can ask for in Slack.