Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe pricing table again #420

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

robertwpaul
Copy link
Member

@robertwpaul robertwpaul commented Jul 12, 2024

🚨 Don't merge this πŸ˜„ 🚨

⚑ THIS IS A LIVE TABLE ⚑

If you purchase through this you will be charged actual real money. If you're keen to test, there's a discount code, which you can ask for in Slack.

Copy link

netlify bot commented Jul 12, 2024

βœ… Deploy Preview for storied-crostata-fa92db ready!

Name Link
πŸ”¨ Latest commit 74bc8e6
πŸ” Latest deploy log https://app.netlify.com/sites/storied-crostata-fa92db/deploys/66916a2112ca880009b4c6f2
😎 Deploy Preview https://deploy-preview-420--storied-crostata-fa92db.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 12, 2024

βœ… Deploy Preview for dreamy-paletas-cb5e15 ready!

Name Link
πŸ”¨ Latest commit 74bc8e6
πŸ” Latest deploy log https://app.netlify.com/sites/dreamy-paletas-cb5e15/deploys/66916a21ee35e50008623c58
😎 Deploy Preview https://deploy-preview-420--dreamy-paletas-cb5e15.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alistairjcbrown alistairjcbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we're not ready to ship, but this looks really good!
Added a few thoughts + comments

@@ -18,92 +18,24 @@
</div>

<div class="row">
<div class="small-12 columns">
Copy link
Member

@alistairjcbrown alistairjcbrown Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Does removing this class do anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I removed this specifically (likely faffing around with the pricing table width), though small-12 is just width: 100%, so I think it only makes sense if you're setting different widths at different breakpoints, right? Otherwise the div's width is always 100%.

<script async src="https://js.stripe.com/v3/pricing-table.js"></script>
<stripe-pricing-table pricing-table-id="prctbl_1PYSAdHVcZRgX183ab67RI0g"
publishable-key="pk_live_1sIaEOF4fdxq136517FMhqG0">
</stripe-pricing-table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Do we need to do anything in case the Pricing Table doesn't load (for whatever reason)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good question. I didn't see anything in the Stripe documentation about it, so...no? It loads a custom element so we could check with something like

const pricingTableLoaded = !!customElements.get('stripe-pricing-table');

if (!pricingTableLoaded) {
  // insert fallback
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants