fix(version bumping): changes according to node apn and GCM pacakge #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivang007
reviewed
Sep 29, 2020
| console.error('ERROR: Push server could not find certData'); | ||
| } | ||
|
|
||
| // Check key data | ||
| if (!options.apn.keyData || !options.apn.keyData.length) { | ||
| if (!options.apn.key || !options.apn.key.length) |
There was a problem hiding this comment.
@MrSpark2591 you forgot to open the curly braces here 😭 😭 😭
shivang007
reviewed
Sep 29, 2020
| key: Assets.getText('apnDevKey.pem'), | ||
| passphrase: 'xxxxxxxxx', | ||
| production: true, | ||
| topic: 'com.your.app.identifier' //required |
There was a problem hiding this comment.
@MrSpark2591 It would be really useful if you could give some details on this topic key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.