Fixing issue 35 #36
Merged
Fixing issue 35 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return filter, nil | ||
| // the cosmic-ray probability (i.e., a cosmic ray corrupts your system). | ||
| return nil, errors.New("too many iterations") |
There was a problem hiding this comment.
would be better to define this as an exported error and return the error instead.
i.e.
var ErrTooManyIterations = errors.New("too many iterations")
...
return nil, ErrTooManyIterationswhen testing this, you can you the explicit exported variable instead of comparing strings.
There was a problem hiding this comment.
Good point. Want to issue a pull request?
There was a problem hiding this comment.
my computer isn't set up for that at the moment.. but maybe you could roll this onto the next set of changes you'll make ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35