-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneccessary CI files for RP2040/RP2350 #1699
Conversation
This causes our RP2350 builds to fail. Do I need to update the repo that we are pointing to?
|
..Yeah. It refuses to do a |
Interesting. I've also added the "RP2040 but with Arduino-Pico instead of ArduinoCore-mbed" and it's discovered a.. compiler bug? job logs.
I need to look into this some more. |
I've disabled FASTLED_RP2040_CLOCKLESS_M0_FALLBACK and this might have fixed your issues. We had a lot of assembly code. The comment says it's default disabled but the code was for default enabled. fe5b54f |
So still failing. Here are some notes on your build: You are using a platform arg which doesn't exist in the build_template_custom_board. Everything is overridden in the args. However, there is also the custom board options in ci/ci-compile.py file. This is done so that developers can run the ci/ci-compile.py tool and get a pretty close approximation to the github builders. Recommendations
|
I've explicitly added that one. So that you don't need the entire custom boards folder anymore, because a platform install first will enable regular project creation with the board ID. I'll still refactor it to actually get rid of the platform URLs in the ci_compile.py then. |
..yeah, giving up on cleaning up the CI build to remove the |
It's complicated because it's fast and concurrent. Github runners have massive bandwidth so installing all the platforms at the same time makes a lot of sense. I've also done a trick to make every example not have to re-compile the entire project. This brings down compilation down to a small fraction of what it would normally take. All these tricks summed together shave off 2/3rds of the build time. The fact that it is used for only one board at a time was a recent development and it just works. That's why it's complicated. Is it too complicated for a single board compilation? Yes it is. I'll investigate using your |
I've refactored the ci-compile.py program and now it's much easier to make changes. I'm now ready to do the pio pkg install feature. Here is my package definition for rpico2: RPI_PICO2 = Project(
board_name="rpipico2",
platform="https://github.com/maxgerhardt/platform-raspberrypi.git",
platform_packages="framework-arduinopico@https://github.com/earlephilhower/arduino-pico.git",
framework="arduino",
board_build_core="earlephilhower",
board_build_filesystem_size="0.5m",
) Given this set of attributes, can you give me just one example of how to use |
Sure. Docs. Nothing else must be pkg-installed to use the |
This isn't working for me: # First command works
pio pkg install -g -p https://github.com/maxgerhardt/platform-raspberrypi.git
# Second one does not.
pio project init --project-dir .build/rpipico2 --board rpipico2 --project-option=platform=https://github.com/maxgerhardt/platform-raspberrypi.git --project-option=platform_packages=framework-arduinopico@https://github.com/earlephilhower/arduino-pico.git --project-option=framework=arduino --project-option=board_build.core=earlephilhower --project-ackages=framework-arduinoption=board_build.filesystem_size=0.5m Output:
Am I doing this wrong? |
looks like i have a typo and some build rules not being generated correctly |
Okay everything is working now and I've removed the custom board injection hack. |
With maxgerhardt/platform-raspberrypi#72 merged, you don't need to locally store the board definitions in the repo anymore. The board definitions of the platform work just fine.