Skip to content

Fix narrowing conversion for port numbers #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

Fix narrowing conversion for port numbers #23

merged 1 commit into from
May 1, 2024

Conversation

TrentHouliston
Copy link
Member

No description provided.

@TrentHouliston TrentHouliston enabled auto-merge (squash) May 1, 2024 05:31
JosephusPaye
JosephusPaye approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@JosephusPaye JosephusPaye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Going forward we should probably bump versions in a separate commit, so it's easier to see in the commit history.

@TrentHouliston TrentHouliston merged commit 5d934c7 into main May 1, 2024
@TrentHouliston TrentHouliston deleted the houliston/narrowing branch May 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephusPaye JosephusPaye JosephusPaye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrentHouliston @JosephusPaye