Feature/manager #414
Draft
Feature/manager #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FasterSpeeding
commented
Aug 7, 2024
FasterSpeeding
force-pushed
the
feature/manager
branch
from
b4f8482 to
8c69bfb
Compare
FasterSpeeding
force-pushed
the
feature/manager
branch
from
ddc6ac5 to
6f15b74
Compare
FasterSpeeding
commented
Oct 10, 2024
| self._cleanup = callback | ||
| return callback | ||
|
|
||
| def with_async_cleanup( |
FasterSpeeding
commented
Oct 10, 2024
alluka/managed/_index.py
Outdated
|
|
||
| def __enter__(self) -> None: | ||
| self._lock.__enter__() | ||
|
|
There was a problem hiding this comment.
get rid of the locking for now
FasterSpeeding
force-pushed
the
feature/manager
branch
from
6f15b74 to
c83f986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues