Message and slash checks for components #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -576,7 +628,11 @@ def unbind_client(self, client: abc.Client, /) -> None: | |||
| self._client = None | |||
|
|
|||
| async def _check_context(self, ctx: abc.Context, /) -> bool: | |||
| return await utilities.gather_checks(ctx, self._checks) | |||
| if abc.SlashContext in type(ctx).mro(): | |||
There was a problem hiding this comment.
Rather than instance check here, we could just specifically call utilitiys.gather_checks(ctx, self._slash_checks/self._message_checks) around line 645 and 656
| @@ -228,6 +242,10 @@ def name(self) -> str: | |||
| def slash_commands(self) -> collections.Collection[abc.BaseSlashCommand]: | |||
| return self._slash_commands.copy().values() | |||
|
|
|||
| @property | |||
| def slash_checks(self) -> collections.Collection[abc.CheckSig]: | |||
| return tuple(check.callback for check in self._slash_checks) | |||
There was a problem hiding this comment.
Could we get a quick 1 line docstring here explaining it
| @@ -236,13 +254,17 @@ def slash_hooks(self) -> typing.Optional[abc.SlashHooks]: | |||
| def message_commands(self) -> collections.Collection[abc.MessageCommand]: | |||
| return self._message_commands.copy() | |||
|
|
|||
| @property | |||
| def message_checks(self) -> collections.Collection[abc.CheckSig]: | |||
There was a problem hiding this comment.
Could we get a quick 1 line docstring here explaining it
|
Looks like you'll also need to rebase now ;3 |
|
Grand Dad |
|
Grand Dad Part 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements message and slash checks on components
Checklist
noxand all the pipelines have passed.Related issues
One of the todo cards iunno