-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typing around callbacks with dynamic keyword-arguments #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FasterSpeeding
changed the title
Improve typing around dependency injection using callbacks
Improve typing around callbacks with dynamic keyword-arguments
Jan 2, 2022
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
5 times, most recently
from
January 9, 2022 23:34
c9e1556
to
0c64eb5
Compare
TODO:
|
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
4 times, most recently
from
January 13, 2022 17:51
3ba0ed8
to
840aa84
Compare
FasterSpeeding
commented
Jan 20, 2022
Probably gonna want to keep the old public-facing type hints but possibly keep them out of the |
Check usages of hook sigs and CheckSig |
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
from
July 22, 2022 08:54
3054f51
to
2466ecb
Compare
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
from
July 30, 2022 06:16
2466ecb
to
5cb81dc
Compare
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
2 times, most recently
from
August 20, 2022 00:25
014a6ea
to
837ec23
Compare
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
2 times, most recently
from
January 22, 2023 22:24
8f77254
to
a6c0d66
Compare
|
FasterSpeeding
commented
Jan 22, 2023
|
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
from
January 24, 2023 01:57
98346ff
to
01ab6f4
Compare
FasterSpeeding
commented
Jan 24, 2023
FasterSpeeding
commented
Jan 24, 2023
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
2 times, most recently
from
January 25, 2023 08:04
a2d89de
to
fc198dd
Compare
FasterSpeeding
force-pushed
the
task/better-callbacks
branch
from
January 30, 2023 05:29
d89313c
to
ee38be0
Compare
FasterSpeeding
commented
Jan 30, 2023
FasterSpeeding
commented
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This uses ParamSpec and Concatenate to partially type signatures which have a set number of positional arguments they must always accept but may by accepting further keyword arguments dynamically (either from DI or command arguments).
Checklist
nox
and all the pipelines have passed.Related issues