Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission normalisation #534

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

FasterSpeeding
Copy link
Owner

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@FasterSpeeding FasterSpeeding changed the title Initial attempt at normalising perms Permission normalisation Oct 31, 2022
| hikari.Permissions.USE_EXTERNAL_STICKERS
| hikari.Permissions.CREATE_PUBLIC_THREADS
| hikari.Permissions.MODERATE_MEMBERS
| ~_CHANNEL_SEND_PERMS
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the best way to do this? (| ~)

hikari.ChannelType.GUILD_PRIVATE_THREAD,
)
)
_MOVABLE_CHANNEL_TYPES = frozenset(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name and document what all these constants are

Base automatically changed from task/hikari-new-release to master November 8, 2022 06:17
@FasterSpeeding FasterSpeeding force-pushed the task/implicit-perm-denies branch 2 times, most recently from f1dff5b to 0d2067f Compare November 22, 2022 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

PR Preview Action ddfa7dc4b5f8fa02675fe5da02ae15c9722367f0
🚀 Deployed preview to https://FasterSpeeding.github.io/Tanjun/pr-preview/pr-534/
on branch docs at 2023-01-31 06:58 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant