Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hot reloading module state bug #813

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

FasterSpeeding
Copy link
Owner

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

PR Preview Action ddfa7dc4b5f8fa02675fe5da02ae15c9722367f0
🚀 Deployed preview to https://FasterSpeeding.github.io/Tanjun/pr-preview/pr-813/
on branch docs at 2023-08-28 18:57 UTC

except Exception as exc:
self._call_loaders(module_path, old_loaders)
modules_dict.pop(module_path)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed module load could have a variant with a field which indicates whether it reverted or not

CHANGELOG.md Outdated
@@ -14,6 +14,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [BasicLocaliser.set_variants][tanjun.dependencies.BasicLocaliser.set_variants]
now tries to normalise the locale keys of variants passed as keyword arguments
to match the [hikari.Locale][hikari.locales.Locale] values.
- The hot-reloader no-longer reverts to a module's old components loaded after
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both reloader and the reload method*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant