Attributes.getValue(String qName) sometimes returns values from previous elements

[nedtwigg]

I have an entity with no attributes. But getValue("SomeKey") is returning a value from a previous element.

I think the problem is that these lines

aalto-xml/src/main/java/com/fasterxml/aalto/sax/SAXParserImpl.java

Lines 654 to 666 in 0820590

	@Override
	public String getValue(String qName)
	{
	int ix = getIndex(qName);
	return (ix < 0) ? null : _attrCollector.getValue(ix);
	}
	@Override
	public String getValue(String uri, String localName)
	{
	int ix = getIndex(uri, localName);
	return (ix < 0) ? null : _attrCollector.getValue(ix);
	}

Are missing the || index >= _attrCount that this has

aalto-xml/src/main/java/com/fasterxml/aalto/sax/SAXParserImpl.java

Lines 647 to 652 in 0820590

	@Override
	public String getValue(int index)
	{
	return (index < 0 || index >= _attrCount) ? null :
	_attrCollector.getValue(index);
	}

[cowtowncoder]

@nedtwigg Apologies for somehow missing this report. I don't know if it'd be possible, but I'd really like a reproduction (I assume "entity" in report means "element") to fix the problem.

I can try to build something on my end based on description and see how that goes; but may need help.

[cowtowncoder]

Ok, no. I do need a test case here to reproduce the problem. And I think the issue is with lookup, not bounds checks; some state is not being cleared, likely.

[nedtwigg]

The thing I was using this for is still alive, but not currently under active development. I did a quick git log to look at the context from 2 years ago, and I can see the workaround in our codebase, but I can't quickly identify a reproducer testcase. I expect this project will become active again sometime in the next few months. When that happens, I'll provide the data here.

[cowtowncoder]

@nedtwigg understood. Thank you for all help you can give.