Skip to content

Commit

Permalink
Add defaults for "build-helper-maven-plugin"
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder committed Nov 3, 2020
1 parent 00639c7 commit 13d6d6d
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 15 deletions.
56 changes: 41 additions & 15 deletions base/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ of Jackson: application code should only rely on `jackson-bom`
</dependency>
</dependencies>

<dependencyManagement>
<dependencies>
<!-- JPMS Libraries-->
<dependency>
<groupId>javax.activation</groupId>
<artifactId>javax.activation-api</artifactId>
<version>${javax.activation.version}</version>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
<!-- JPMS Libraries-->
<dependency>
<groupId>javax.activation</groupId>
<artifactId>javax.activation-api</artifactId>
<version>${javax.activation.version}</version>
</dependency>
</dependencies>

</dependencyManagement>
</dependencyManagement>

<build>
<build>
<pluginManagement>
<plugins>
<!-- Verify existence of certain settings
Expand Down Expand Up @@ -178,13 +178,39 @@ of Jackson: application code should only rely on `jackson-bom`
</platformDependencies>
</configuration>
</plugin>
</plugins>
</pluginManagement>

<!-- And one more odd thing... we actually MUST disable checks just for this
<!-- 03-Nov-2020, tatu: For 2.12, defaults for better LICENSE inclusion -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
<id>add-resource</id>
<phase>generate-resources</phase>
<goals>
<goal>add-resource</goal>
</goals>
<configuration>
<resources>
<resource>
<directory>${project.basedir}</directory>
<targetPath>META-INF</targetPath>
<includes>
<include>LICENSE</include>
</includes>
</resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>

<!-- And one more odd thing... we actually MUST disable checks just for this
pom (but not on something that extends i)
-->
<plugins>
<plugins>
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
Expand Down
2 changes: 2 additions & 0 deletions release-notes/VERSION
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

- Add another execution of `maven-replacer-plugin` for "prepare-package" phase
to help with IDE import.
- Add default settings for `gradle-module-metadata-maven-plugin` (gradle metadata)
- Add default settings for `build-helper-maven-plugin` (LICENSE inclusion)

2.11.3

Expand Down

0 comments on commit 13d6d6d

Please sign in to comment.