Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module-info.java is in META-INF/versions/11 instead of META-INF/versions/9 #46

Closed
cowtowncoder opened this issue Jan 27, 2022 · 0 comments
Closed

module-info.java is in META-INF/versions/11 instead of META-INF/versions/9 #46

cowtowncoder opened this issue Jan 27, 2022 · 0 comments
Milestone
2.13.2

Comments

@cowtowncoder
Copy link
Member

(note: fix for FasterXML/jackson-databind#3380 and https://github.com/FasterXML/jackson/issues/96)

It seems that there are downsides to 2.13.0 (and 2.13.1) change to move module-info.java to under JDK 11 - specific location.
While no one should be using JDK 9 per se, tooling infers certain things from location, so it seems better to imply JDK 9 minimum instead.

This definition defaults via jackson-base so change would go in this repo.
cowtowncoder added a commit that referenced this issue Jan 27, 2022
@cowtowncoder
Fix #46: move module info to under META-INF/versions/9
e8f3c79
@cowtowncoder cowtowncoder mentioned this issue Jan 27, 2022
Merged
cowtowncoder added a commit that referenced this issue Jan 28, 2022
@cowtowncoder
Merge pull request #47 from FasterXML/issue-46/module-info-jdk9
7d9e1de 
Fix #46: move module info to under META-INF/versions/9
cowtowncoder added a commit that referenced this issue Jan 28, 2022
@cowtowncoder
Update release notes wrt #46
61321f5
@cowtowncoder cowtowncoder modified the milestones: 2.10.5, 2.13.2 Jan 28, 2022
@cowtowncoder cowtowncoder mentioned this issue Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.2
Development

No branches or pull requests
1 participant
@cowtowncoder