Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create NonStandardNumberParsing4694Test.java #1334

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Create NonStandardNumberParsing4694Test.java #1334

merged 3 commits into from
Sep 12, 2024

Conversation

pjfanning
Copy link
Member

another test for #1331 - I think this and #1332 are both useful in their own rights

cowtowncoder
cowtowncoder approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful on its own right, agreed. Will probably rename as it's not testing non-standard numbers, after merging.

@cowtowncoder cowtowncoder merged commit 8e4c3a8 into FasterXML:2.18 Sep 12, 2024
9 checks passed
cowtowncoder added a commit that referenced this pull request Sep 12, 2024
@cowtowncoder
Rename post #1334
5606536
@pjfanning pjfanning deleted the failing-4964 branch September 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @cowtowncoder